[Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

[Victor Toso]

On Tue, Feb 20, 2018 at 11:21:47AM +0100, Lukáš Hrázký wrote:
> On Tue, 2018-02-20 at 11:02 +0100, Victor Toso wrote:
> > IMHO, tests are a must for development and should be optional
> > on tarballs from releases. That means that packagers can
> > enable it and deal with whatever we do for testing if they
> > want to.
> 
> Thing is, there shouldn't be much (if really anything) you have
> to deal with for unittests... It's certainly the case atm.

For us. If we request Catch and Catch is not there for DISTROX,
they have to disable it in order to have build working or install
Catch. IMHO, for released tarballs one should enable testing if
they want to, not disable if they must.
 
> > More importantly is that we have tests running successfully on
> > some Linux distros (IMO, Fedora and Debian should be enough) and
> > that's why gitlab-ci is there for.
> 
> You have different versions of dependencies on different
> distros, so Fedora and Debian are not entirely enough. And if
> you do it properly, having the benefit of the tests being run
> on each distro it's packaged for doesn't cost much... (I'd say
> the benefit is more for the distros, we are basically helping
> them by forcing the tests on them :D)

I say Fedora and Debian due .rpm and .deb which several distros
might follow so we benefit on testing those two... but if we
care, then we should enable some unit test in the CI.

> > Also IMO, if we change the behavior of unit tests here, we
> > should do for all Spice components in order to be consistent.
> 
> You mean the fact that we run them during packaging?

That tests are not enabled by default. If we enable it by default
here I would expect to do the same for other Spice components.

Cheers,
        toso
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180220/608298bb/attachment.sig>