[Spice-devel] [PATCH spice-streaming-agent] Remove usage of ERROR macro

[Christophe de Dinechin]

> On 20 Feb 2018, at 13:13, Frediano Ziglio <fziglio at redhat.com> wrote:
> 
> Use more simple syntax for throwing errors.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
> src/mjpeg-fallback.cpp | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/src/mjpeg-fallback.cpp b/src/mjpeg-fallback.cpp
> index cf704c6..fd37167 100644
> --- a/src/mjpeg-fallback.cpp
> +++ b/src/mjpeg-fallback.cpp
> @@ -19,12 +19,6 @@
> 
> using namespace spice::streaming_agent;
> 
> -#define ERROR(args) do { \
> -    std::ostringstream _s; \
> -    _s << args; \
> -    throw std::runtime_error(_s.str()); \
> -} while(0)
> -
> static inline uint64_t get_time()
> {
>     timespec now;
> @@ -65,7 +59,7 @@ MjpegFrameCapture::MjpegFrameCapture(const MjpegSettings& settings):
> {
>     dpy = XOpenDisplay(NULL);
>     if (!dpy)
> -        ERROR("Unable to initialize X11");
> +        throw std::runtime_error("Unable to initialize X11”);

That reminds me of a question I had at some point… Do we need to address localization?

> }
> 
> MjpegFrameCapture::~MjpegFrameCapture()
> -- 
> 2.14.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel