[Spice-devel] [RFC PATCH spice-streaming-agent] Remove paranoid warning

Victor Toso victortoso at redhat.com
Fri Feb 23 10:28:33 UTC 2018


On Fri, Feb 23, 2018 at 10:15:47AM +0000, Frediano Ziglio wrote:
> Fields are initialized to zero if not explicitly specified which is
> actually what you usually want so there's no reason to have the
> compiler to generate warning for this.

So, s/paranoid/useless/ ?

> 
> ---
>  m4/spice-compile-warnings.m4  |  1 +
>  src/spice-streaming-agent.cpp | 11 ++++-------
>  2 files changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/m4/spice-compile-warnings.m4 b/m4/spice-compile-warnings.m4
> index 66d7179..5f415cd 100644
> --- a/m4/spice-compile-warnings.m4
> +++ b/m4/spice-compile-warnings.m4
> @@ -108,6 +108,7 @@ AC_DEFUN([SPICE_COMPILE_WARNINGS],[
>      # So we have -W enabled, and then have to explicitly turn off...
>      gl_WARN_ADD([-Wno-sign-compare])
>      gl_WARN_ADD([-Wno-unused-parameter])
> +    gl_WARN_ADD([-Wno-missing-field-initializers])
>      # We can't enable this due to horrible spice_usb_device_get_description
>      # signature
>      gl_WARN_ADD([-Wno-format-nonliteral])
> -- 
> 2.14.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180223/ba92e28b/attachment.sig>


More information about the Spice-devel mailing list