[Spice-devel] [PATCH spice-streaming-agent 1/1] Adding gstreamer based plugin

[Victor Toso]

Hi,

On Fri, Feb 23, 2018 at 01:14:47PM +0100, Christophe de Dinechin wrote:
> > +    sink = gst_element_factory_make("appsink", "sink");
> > +    if (!capture || !convert || !encoder || !sink) {
> > +        //TODO: check elements existence in build time (and\or improve error in runtime)
> 
> - “at” build time?
> - How would you check at build time?

Something like this, I guess:
https://gitlab.com/spice/spice-gtk/commit/8891be2c2d0347fbfc196973919c#87db583be5c13c1f7b3c958b10e03d67b6a2ca06_269_274

> - not freeing the resources you allocated? (Note that you are in ctor, can’t rely on dtor)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180223/6c0a10a3/attachment.sig>