[Spice-devel] [PATCH spice-streaming-agent] Only build unit tests when running make check

[Frediano Ziglio]

> 
> Removing noinst_PROGRAMS from src/unittests/Makefile.am will cause the
> unit tests not be built on a regular build (`make`), they will only be
> built when running the tests (`make check`).
> 
> C++ unit test frameworks are notorious for long build times too.
> 
> Signed-off-by: Lukáš Hrázký <lhrazky at redhat.com>
> ---
> I am not sure if there was another reason for noinst_PROGRAMS, but I
> don't think so.
> 

Yes, this is mainly what it does. In spice-server we have same pattern,
the reason to have it is the opposite of this patch, we want to make
sure tests compile even if they are not executed.

If the final aim of this patch is to avoid the requirement of catch
library this patch is just partial.

If the aim is to just save some time avoiding to compile tests
the patch is fine but looks like presenting different behaviour
comparing to other SPICE projects.

>  src/unittests/Makefile.am | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/unittests/Makefile.am b/src/unittests/Makefile.am
> index 0fc6d50..cf7adba 100644
> --- a/src/unittests/Makefile.am
> +++ b/src/unittests/Makefile.am
> @@ -23,10 +23,6 @@ TESTS = \
>  	test-mjpeg-fallback \
>  	$(NULL)
>  
> -noinst_PROGRAMS = \
> -	$(check_PROGRAMS) \
> -	$(NULL)
> -
>  hexdump_SOURCES = \
>  	hexdump.c \
>  	$(NULL)

Frediano