[Spice-devel] [spice-gtk v1] channel-usbredir: avoid calling memcpy() will NULL src

Victor Toso victortoso at redhat.com
Wed Feb 28 17:18:22 UTC 2018


From: Victor Toso <me at victortoso.com>

Code built with address sanitizer has runtime error:
 > channel-usbredir.c:642:5: runtime error: null pointer passed
 > as argument 2, which is declared to never be null

Signed-off-by: Victor Toso <victortoso at redhat.com>
---
 src/channel-usbredir.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
index 1f791bc..7c48ecb 100644
--- a/src/channel-usbredir.c
+++ b/src/channel-usbredir.c
@@ -635,9 +635,9 @@ static int usbredir_read_callback(void *user_data, uint8_t *data, int count)
     SpiceUsbredirChannel *channel = user_data;
     SpiceUsbredirChannelPrivate *priv = channel->priv;
 
-    if (priv->read_buf_size < count) {
-        count = priv->read_buf_size;
-    }
+    count = MIN(priv->read_buf_size, count);
+    if (count == 0)
+        return 0;
 
     memcpy(data, priv->read_buf, count);
 
-- 
2.16.2



More information about the Spice-devel mailing list