[Spice-devel] [PATCH spice-server v3 03/12] red-stream: Avoid to specify 2 mech names during SASL

[Frediano Ziglio]

> Hi

> On 12/22/2017 12:07 PM, Frediano Ziglio wrote:

> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com> ---
> 
> > server/red-stream.c | 2 +-
> 
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> 

> > diff --git a/server/red-stream.c b/server/red-stream.c
> 
> > index 3dbdfca82..fccad8b27 100644
> 
> > --- a/server/red-stream.c
> 
> > +++ b/server/red-stream.c
> 
> > @@ -987,7 +987,7 @@ bool red_sasl_handle_auth_mechname(RedStream *stream,
> > AsyncReadDone read_cb, voi
> 
> > char quoted_mechname[SASL_MAX_MECHNAME_LEN + 4];
> 
> > sprintf(quoted_mechname, ",%s,", sasl->mechname);
> 
> > 
> 
> > -    if (strstr(sasl->mechlist, quoted_mechname) == NULL) {
> 
> > +    if (strchr(sasl->mechname, ',') || strstr(sasl->mechlist,
> > quoted_mechname) == NULL) {
> 
> > return false;
> 
> > }
> 

> Acked-by: Snir Sheriber <ssheribe at redhat.com>
> ( Maybe can be merged with the first patch? )

It touches the same lines but it a completely different issue and
rationale.

> Snir.

Frediano