[Spice-devel] [RFC PATCH 0/3] Flush interface and TCP_CORK

[Christophe Fergeau]

On Wed, Jan 10, 2018 at 11:39:32AM -0500, Frediano Ziglio wrote:
> > 
> > Hey,
> > 
> > On Fri, Dec 15, 2017 at 04:33:26AM -0500, Frediano Ziglio wrote:
> > > ping
> > 
> > So I finally took a quick look at this, patch 2/3 and 3/3 really deserve
> > a more detailed commit log/rationale/..., they cannot have just a
> > shortlog. Apart from that, they seemed ok, though we don't really have a
> > way to compare before/after to see what changes :-/
> > 
> > Christophe
> > 
> 
> Send quite some mail in the past on how to measure the changes and the results.
> Roughly define some tests (like using replay with real time), use a specific
> bandwidth/latency/connection, record the capture and to some measure (wireshark
> statistics or others).
> 
> One is https://lists.freedesktop.org/archives/spice-devel/2017-February/035577.html.

I would add part of these results to the commit log.

> 
> Next question is: Shouldn't we (everybody in the SPICE team) have a rough method
> to do these testing?

Yes, this is what I meant, we can for sure do some individual
measurement, but we don't have some "project-wide" tool that everyone
uses for such things ;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180110/b0288166/attachment-0001.sig>