[Spice-devel] [PATCH spice-server] red-parse-qxl: Copy correctly brush position

[Frediano Ziglio]

> 2018-01-13 11:08 GMT+01:00 Frediano Ziglio < fziglio at redhat.com > :

> > This issue caused the glitches using the rectangular selection
> 
> > tool in PaintShop 6.
> 

> > The line was removed accidentally by "red_parse_qxl: fix throwing
> 
> > away drawables that have masks" (812b65984d286414170c6243bd3323b73a405ec3)
> 

> quite old

Filling an area with a pattern is nowadays not that common. In case of this
bug happening in Windows 7 you see the glitches as the Windows graphic engine
does some drawing on its own. On Windows XP won't happen because it would do
these drawing using graphic driver while on Windows 10 would do all these drawing
on the engine.

Having more tests would have prevented these kind of regressions.

> > Signed-off-by: Frediano Ziglio < fziglio at redhat.com >
> 

> Ack,
> Pavel

Thanks,
  Frediano

> > ---
> 
> > server/red-parse-qxl.c | 1 +
> 
> > 1 file changed, 1 insertion(+)
> 

> > diff --git a/server/red-parse-qxl.c b/server/red-parse-qxl.c
> 
> > index b4325b048..69748698a 100644
> 
> > --- a/server/red-parse-qxl.c
> 
> > +++ b/server/red-parse-qxl.c
> 
> > @@ -616,6 +616,7 @@ static void red_get_brush_ptr(RedMemSlotInfo *slots,
> > int
> > group_id,
> 
> > break;
> 
> > case SPICE_BRUSH_TYPE_PATTERN:
> 
> > red->u.pattern.pat = red_get_image(slots, group_id, qxl->u.pattern.pat,
> > flags, false);
> 
> > + red_get_point_ptr(&red->u.pattern.pos, &qxl->u.pattern.pos);
> 
> > break;
> 
> > }
> 
> > }
>