[Spice-devel] [PATCH spice-server] red-stream: Remove AsyncRead::stream

[Christophe Fergeau]

On Tue, Jan 16, 2018 at 08:59:14AM -0500, Frediano Ziglio wrote:
> Yes, is handling a particular case (reading 0 bytes) directly instead of
> adding a pending operation. It can be useful if you have a sequence length+data
> where length can be 0. Currently cannot happen (size is always > 0), in
> red_sasl_handle_auth_steplen where you have a sequence like that you handle
> the size == 0 case explicitly with a "if (len == 0) {".
> 
> But you are right, is not part of the rationale although IMHO should be a
> handled case. I'll remove from the patch.

I'm totally fine with this change in a separate patch, I just don't want
the commit under review to change behaviour.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180116/3298fad9/attachment-0001.sig>