[Spice-devel] [PATCH spice-server 0.12] red-parse-qxl: Copy correctly brush position

[Uri Lublin]

On 01/19/2018 12:08 PM, Frediano Ziglio wrote:
> This issue caused the glitches using the rectangular selection
> tool in PaintShop 6.
> 
> The line was removed accidentally by "red_parse_qxl: fix throwing
> away drawables that have masks" (812b65984d286414170c6243bd3323b73a405ec3)
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> Acked-by: Pavel Grunt <pavelgrunt at gmail.com>

Yes, it's missing in branch 0.12 too.
Ack.

Uri.

> ---
>   server/red_parse_qxl.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> This patch is a backport for 0.12 branch.
> Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94854 and
> https://bugs.freedesktop.org/show_bug.cgi?id=77762.
> 
> diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c
> index 52425d4c..f1902e7f 100644
> --- a/server/red_parse_qxl.c
> +++ b/server/red_parse_qxl.c
> @@ -596,6 +596,7 @@ static void red_get_brush_ptr(RedMemSlotInfo *slots, int group_id,
>           break;
>       case SPICE_BRUSH_TYPE_PATTERN:
>           red->u.pattern.pat = red_get_image(slots, group_id, qxl->u.pattern.pat, flags, FALSE);
> +        red_get_point_ptr(&red->u.pattern.pos, &qxl->u.pattern.pos);
>           break;
>       }
>   }
>