[Spice-devel] [PATCH spice-streaming-agent v2 4/4] better error message when opening streaming device

[Frediano Ziglio]

> 
> Signed-off-by: Lukáš Hrázký <lhrazky at redhat.com>
> ---
>  src/spice-streaming-agent.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
> index 87e8fa3..0200e4a 100644
> --- a/src/spice-streaming-agent.cpp
> +++ b/src/spice-streaming-agent.cpp
> @@ -356,7 +356,8 @@ do_capture(const string &streamport, FILE *f_log)
>      streamfd = open(streamport.c_str(), O_RDWR);
>      if (streamfd < 0)
>          // TODO was syslog(LOG_ERR, "Failed to open %s: %s\n", streamport,
>          strerror(errno));
> -        throw std::runtime_error("failed to open streaming device");
> +        throw std::runtime_error("failed to open the streaming device (" +
> +            streamport + "): " + string(strerror(errno)));
> 

The last string constructor explicit call is not necessary.
Are we use that when we'll read errno will still contain the error from open?
Maybe it works but potentially can be overwritten at that time, code needs
to call different constructors/add operators before getting errno and call
strerror.
I think also this commit fix the above TODO which could then be removed.
We usually align after the "(" but I'm fine with this alignment.
 
>      unsigned int frame_count = 0;
>      while (! quit) {

Frediano