[Spice-devel] [PATCH spice-gtk] Fix setting appsrc properties in i686 arch
Frediano Ziglio
fziglio at redhat.com
Fri Jan 26 13:58:40 UTC 2018
>
> The "max-bytes" property of the appsrc GStreamer element expects a
> 64-bit value. Calling:
> g_object_set(source, "max-bytes", 0, NULL);
> in a 32-bit architecture ends up with a wrong value, it must be cast to
> a long long int:
> g_object_set(source, "max-bytes", 0LL, NULL);
> ---
> src/channel-display-gst.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
> index f978602..c872a1f 100644
> --- a/src/channel-display-gst.c
> +++ b/src/channel-display-gst.c
> @@ -333,7 +333,7 @@ static void app_source_setup(GstElement *pipeline
> G_GNUC_UNUSED,
> "caps", caps,
> "is-live", TRUE,
> "format", GST_FORMAT_TIME,
> - "max-bytes", 0,
> + "max-bytes", 0LL,
> "block", TRUE,
> NULL);
> gst_caps_unref(caps);
I would use a gint64 cast instead.
Beside that patch is fine.
Frediano
More information about the Spice-devel
mailing list