[Spice-devel] [PATCH spice-streaming-agent v3 4/4] better error message when opening streaming device

[Frediano Ziglio]

> 
> Signed-off-by: Lukáš Hrázký <lhrazky at redhat.com>

Acked-by: Frediano Ziglio <fziglio at redhat.com>

> ---
> (rant alert :) I find this alignment quite unfortunate, while in this
> case it's all fine and pretty, if there was more stuff in there, with
> such big indent there is little space for it which makes it
> unnecessarily harder to format and read and it takes up more vertical
> space.
> 
>  src/spice-streaming-agent.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
> index 87e8fa3..ad52277 100644
> --- a/src/spice-streaming-agent.cpp
> +++ b/src/spice-streaming-agent.cpp
> @@ -355,8 +355,8 @@ do_capture(const string &streamport, FILE *f_log)
>  
>      streamfd = open(streamport.c_str(), O_RDWR);
>      if (streamfd < 0)
> -        // TODO was syslog(LOG_ERR, "Failed to open %s: %s\n", streamport,
> strerror(errno));
> -        throw std::runtime_error("failed to open streaming device");
> +        throw std::runtime_error("failed to open the streaming device (" +
> +                                 streamport + "): " + strerror(errno));
>  
>      unsigned int frame_count = 0;
>      while (! quit) {