[Spice-devel] [PATCH spice-streaming-agent] build: Do not use top_srcdir if not necessary

[Christophe de Dinechin]

> On 29 Jan 2018, at 12:00, Frediano Ziglio <fziglio at redhat.com> wrote:
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
> Makefile.am | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index baa9835..74ec16a 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -6,11 +6,11 @@ SUBDIRS = \
> 
> # this will start the program for each user session
> xdgautostartdir = $(sysconfdir)/xdg/autostart
> -xdgautostart_DATA = $(top_srcdir)/data/spice-streaming.desktop
> +xdgautostart_DATA = $(srcdir)/data/spice-streaming.desktop

Could you clarify why it helps in the commit message?
Did you run into a problem integrating that in a higher-level project?

Seems to be an enhancement for me anyway, so if you explain
why this is incorrect in the commit message…

Acked-by: Christophe de Dinechin <dinechin at redhat.com> 


> # this will start the program for the login session
> gdmautostartdir = $(datadir)/gdm/greeter/autostart
> -gdmautostart_DATA = $(top_srcdir)/data/spice-streaming.desktop
> +gdmautostart_DATA = $(srcdir)/data/spice-streaming.desktop
> 
> pkgconfigdir = $(libdir)/pkgconfig
> pkgconfig_DATA = spice-streaming-agent.pc
> -- 
> 2.14.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel