[Spice-devel] [spice-gtk] channel-display: Removed only assigned dc field from _SpiceDisplayChannelPrivate

[Christophe de Dinechin]

Curious what the rationale was for this field to start with.
I would like an explanation of why it’s OK to remove it now
in the commit message.

Otherwise
Acked-by: Christophe de Dinechin <dinechin at redhat.com> 


> On 18 Jan 2018, at 16:05, Frediano Ziglio <fziglio at redhat.com> wrote:
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
> src/channel-display.c | 17 -----------------
> 1 file changed, 17 deletions(-)
> 
> This is a follow up to "GDI canvas cleanup".
> 
> diff --git a/src/channel-display.c b/src/channel-display.c
> index 84ad4af..45fe38c 100644
> --- a/src/channel-display.c
> +++ b/src/channel-display.c
> @@ -70,9 +70,6 @@ struct _SpiceDisplayChannelPrivate {
>     GArray                      *monitors;
>     guint                       monitors_max;
>     gboolean                    enable_adaptive_streaming;
> -#ifdef G_OS_WIN32
> -    HDC dc;
> -#endif
>     SpiceGlScanout scanout;
> };
> 
> @@ -821,17 +818,6 @@ static SpiceImageSurfacesOps image_surfaces_ops = {
>     .get = surfaces_get
> };
> 
> -#if defined(G_OS_WIN32)
> -static HDC create_compatible_dc(void)
> -{
> -    HDC dc = CreateCompatibleDC(NULL);
> -    if (!dc) {
> -        g_warning("create compatible DC failed");
> -    }
> -    return dc;
> -}
> -#endif
> -
> static void spice_display_channel_reset_capabilities(SpiceChannel *channel)
> {
>     guint i;
> @@ -880,9 +866,6 @@ static void spice_display_channel_init(SpiceDisplayChannel *channel)
>     c->image_cache.ops = &image_cache_ops;
>     c->palette_cache.ops = &palette_cache_ops;
>     c->image_surfaces.ops = &image_surfaces_ops;
> -#if defined(G_OS_WIN32)
> -    c->dc = create_compatible_dc();
> -#endif
>     c->monitors_max = 1;
>     c->scanout.fd = -1;
> 
> -- 
> 2.14.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel