[Spice-devel] [PATCH spice-streaming-agent 1/4] configure.ac: remove header check for stream-device.h

Frediano Ziglio fziglio at redhat.com
Wed Jan 31 12:42:33 UTC 2018


> 
> The pkg-config version check should be enough to ensure we have the
> correct version of spice-protocol which contains this header.
> 
> Signed-off-by: Lukáš Hrázký <lhrazky at redhat.com>

Acked-by: Frediano Ziglio <fziglio at redhat.com>

I think this was here just for 0.12.13, we forget to remove the
additional check, now 0.12.14 has the header.

I would a bit rephrase:

"The pkg-config version check is enough to ensure we have the
correct version of spice-protocol which contains this header."

Frediano

> ---
>  configure.ac | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 1d86200..8795dae 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -31,10 +31,6 @@ dnl Check deps
>  SPICE_PROTOCOL_MIN_VER=0.12.14
>  PKG_CHECK_MODULES([SPICE_PROTOCOL], [spice-protocol >=
>  $SPICE_PROTOCOL_MIN_VER])
>  AC_SUBST([SPICE_PROTOCOL_MIN_VER])
> -SAVE_CFLAGS="$CFLAGS"
> -CFLAGS="$SPICE_PROTOCOL_CFLAGS $CFLAGS"
> -AC_CHECK_HEADER([spice/stream-device.h],,[AC_MSG_ERROR([Could not locate
> spice-protocol stream-device.h header])])
> -CFLAGS="$SAVE_CFLAGS"
>  
>  PKG_CHECK_MODULES(X11, x11)
>  PKG_CHECK_MODULES(XFIXES, xfixes)


More information about the Spice-devel mailing list