[Spice-devel] [vdagent-win PATCH v4 00/19] Miscellaneous patches

Frediano Ziglio fziglio at redhat.com
Mon Jul 2 07:43:39 UTC 2018


Changes sinve v3:
- split factor out patch;
- rework destructor patch;
- rework log.

Changes since v2:
- change a bit some style to make following patches easier;
- split patch for small overflows.

Frediano Ziglio (19):
  Use proper type for _clipboard_owner
  Reduce indentation returning earlier
  Minor overflow checks improvements
  Replace an assert with proper handling code
  Use always TCHAR to read string from registry
  Factor out an utility function to read strings from registry
  Allow one more character reading strings from registry
  Use GetModuleHandle to get some functions from user32 library
  Use proper invalid value for _vio_serial
  Use std::unique_ptr for _desktop_layout
  Allocate _control_event and _stop_event just once
  Introduce an helper to close VirtIo device
  Use destructor instead of cleanup function
  Avoid declaring event_thread_id
  Avoids declaring _system_version member
  Avoids to call supported_system_version()
  vdlog: Avoids to having a lookup table for log types
  vdlog: Factor our a "logf" function to avoid long "LOG" macro
  vdlog: Use GetLocalTime instead of multiple C functions

 common/vdlog.cpp            |  23 ++++++
 common/vdlog.h              |  28 +++----
 spice-protocol              |   2 +-
 vdagent/display_setting.cpp | 103 +++++++++++++-------------
 vdagent/vdagent.cpp         | 144 ++++++++++++++++++++----------------
 5 files changed, 166 insertions(+), 134 deletions(-)

-- 
2.17.1



More information about the Spice-devel mailing list