[Spice-devel] [PATCH spice-gtk] Replace spice_printerr() with g_warning()

[Frediano Ziglio]

> 
> On Fri, Jun 29, 2018 at 02:56:06PM -0400, Frediano Ziglio wrote:
> > > 
> > > On Thu, Jun 28, 2018 at 04:38:21PM +0100, Frediano Ziglio wrote:
> > > > The remaining occurrences of spice_printerr() are warnings when
> > > > something unexpected happens, they can be replaced with g_warning() so
> > > > that users of spice-server can redirect them with
> > > > g_log_set_default_handler().
> > > 
> > > Maybe squash this in?
> > > 
> > > Either way, Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> > > 
> > 
> > I can do a follow up but IMO they don't see to help much, surely
> > is the display channel and knowing the id of which one means
> > that you have multiple video running on the same VM.
> > I mean, looks like a peculiar situation you don't want to
> > have so many detail in the normal case...
> 
> Imo, we should always prefix log messages with the channel name when
> they are related to a channel. This way when I look at eg a sound
> channel issue, if I get this warning at the same time, I don't have to
> wonder if 'stream' relates to sound somehow, or if it's something
> different.
> 
> Christophe
> 

Oh, so was a coherence suggestion.
Not much to do with a API change, isn't it?
I don't think you as a person will have problems, but you as a grep/whatever
user could benefit by coherences like these

Frediano