[Spice-devel] [PATCH spice-common] Update gitlab-ci to use meson

[Christophe de Dinechin]

> On 2 Jul 2018, at 18:23, Frediano Ziglio <fziglio at redhat.com> wrote:
> 
> 
> 
> ----- Original Message -----
>> From: "Christophe de Dinechin" <cdupontd at redhat.com>
>> To: "Eduardo Lima (Etrunko)" <etrunko at redhat.com>
>> Cc: spice-devel at lists.freedesktop.org
>> Sent: Monday, 2 July, 2018 3:01:41 PM
>> Subject: Re: [Spice-devel] [PATCH spice-common] Update gitlab-ci to use meson
>> 
>> 
>> 
>>> On 29 Jun 2018, at 21:33, Eduardo Lima (Etrunko) <etrunko at redhat.com>
>>> wrote:
>>> 
>>> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
>>> ---
>>> v2: - Remove unecessary setup steps
>>>   - Dump meson-log.txt in case of error.
>>> 
>>> .gitlab-ci.yml | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>> 
>>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>>> index d1288ec..54b0161 100644
>>> --- a/.gitlab-ci.yml
>>> +++ b/.gitlab-ci.yml
>>> @@ -4,6 +4,7 @@ before_script:
>>>  - >
>>>    dnf install 'dnf-command(copr)' git libtool make libasan
>>>    python3 python3-six python3-pyparsing glib-networking
>>> +    python3-devel meson ninja-build gdk-pixbuf2-devel
>>>    -y
>>>  - dnf copr enable @spice/nightly -y
>>>  - dnf builddep spice -y
>>> @@ -16,3 +17,12 @@ makecheck:
>>>    ./autogen.sh --enable-extra-checks --enable-celt051
>>>  - make
>>>  - make check || (cat tests/test-suite.log && exit 1)
>> 
>> Shouldn’t we keep two ‘-makecheck’ targets, one for meson and one with
>> autogen? Or is the intent to break ‘make’ at some point?
>> 
> 
> This patch is not removing the other check, maybe you are confused
> with "-" at the beginning of the command, is not the "-" of the diff
> format.

Indeed, I was!

> 
>>> +
>>> +meson-makecheck:
>>> +  script:
>>> +  - >
>>> +    CFLAGS='-O2 -pipe -g -fsanitize=address -fno-omit-frame-pointer
>>> -Wframe-larger-than=40920'
>>> +    LDFLAGS='-fsanitize=address -lasan'
>>> +    meson build -Dextra-checks=true -Dcelt501=true  || (cat
>>> build/meson-logs/meson-log.txt && exit 1)
>>> +  - ninja -C build
>>> +  - cd build && meson test
> 
> Frediano
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel