[Spice-devel] [PATCH spice-common] Update gitlab-ci to use meson
Eduardo Lima (Etrunko)
etrunko at redhat.com
Tue Jul 3 14:36:13 UTC 2018
On 03/07/18 10:35, Frediano Ziglio wrote:
>>
>> On 02/07/18 07:31, Frediano Ziglio wrote:
>>>>
>>>>>
>>>>> Test-region timeouts, maybe we should increase the timeout for all tests?
>>>>>
>>>>> https://gitlab.freedesktop.org/etrunko/spice-common/-/jobs/6546
>>>>>
>>>>
>>>> Maybe just for this test we could decrease the for loop counter
>>>> near the end of this test? If a for loop doing like one million
>>>> random tests.
>>>>
>>>> Frediano
>>>>
>>>>> On 29/06/18 16:33, Eduardo Lima (Etrunko) wrote:
>>>>>> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
>>>>>> ---
>>>>>> v2: - Remove unecessary setup steps
>>>>>> - Dump meson-log.txt in case of error.
>>>>>>
>>>>>> .gitlab-ci.yml | 10 ++++++++++
>>>>>> 1 file changed, 10 insertions(+)
>>>>>>
>>>>>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>>>>>> index d1288ec..54b0161 100644
>>>>>> --- a/.gitlab-ci.yml
>>>>>> +++ b/.gitlab-ci.yml
>>>>>> @@ -4,6 +4,7 @@ before_script:
>>>>>> - >
>>>>>> dnf install 'dnf-command(copr)' git libtool make libasan
>>>>>> python3 python3-six python3-pyparsing glib-networking
>>>>>> + python3-devel meson ninja-build gdk-pixbuf2-devel
>>>>>> -y
>>>>>> - dnf copr enable @spice/nightly -y
>>>>>> - dnf builddep spice -y
>>>>>> @@ -16,3 +17,12 @@ makecheck:
>>>>>> ./autogen.sh --enable-extra-checks --enable-celt051
>>>>>> - make
>>>>>> - make check || (cat tests/test-suite.log && exit 1)
>>>>>> +
>>>>>> +meson-makecheck:
>>>>>> + script:
>>>>>> + - >
>>>>>> + CFLAGS='-O2 -pipe -g -fsanitize=address -fno-omit-frame-pointer
>>>>>> -Wframe-larger-than=40920'
>>>>>> + LDFLAGS='-fsanitize=address -lasan'
>>>>>> + meson build -Dextra-checks=true -Dcelt501=true || (cat
>>>>>> build/meson-logs/meson-log.txt && exit 1)
>>>>>> + - ninja -C build
>>>>>> + - cd build && meson test
>>>>>>
>>>
>>> About the original patch... ack with future follow up?
>>>
>>
>> Just to confirm, the follow up is about decreasing the loop count, not
>> increasing the timeout right??
>>
>
> Either that allows CI to be happy :-)
> I personally would divide by 10 the loop count.
>
> Frediano
>
Both done, ci patch pushed and test-region sent.
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com
More information about the Spice-devel
mailing list