[Spice-devel] [PATCH] Avoid NULL-dereference if canvas_get_image errors out

[Christophe Fergeau]

On Wed, Jul 04, 2018 at 09:22:40AM +0200, Christophe de Dinechin wrote:
> > If that's what
> > you want, I would not bother with the cleanups.
> 
> I want spice_ctitical because that’s what is being used in the file
> today (irrespective of what I may otherwise think about the incredibly
> confusing mess of SPICE and glib logging in general). And since
> spice_critical() may return, I need to leave the cleanup in place at
> the moment.

As already suggested, it will be less confusing to use spice_warning()
instead. The other users of spice_critical() might have wanted the
abort(), here we don't want it, so we should as well use something which
gives us what we want.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180704/e863b72e/attachment.sig>