[Spice-devel] [PATCH spice-common] proto: Improve documentation for stream_report::num_drops
Victor Toso
victortoso at redhat.com
Thu Jul 5 08:26:04 UTC 2018
Hi,
On Wed, Jul 04, 2018 at 06:57:17PM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
> spice.proto | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/spice.proto b/spice.proto
> index e678ef8..3084c2b 100644
> --- a/spice.proto
> +++ b/spice.proto
> @@ -1005,8 +1005,10 @@ channel DisplayChannel : BaseChannel {
> // the stream is not supported or that the client was not able
> // to decode it
> uint32 num_frames;
> - // the part of the above frames that were dropped by the client due
> - // to late arrival time
> + // the number of the above frames that were dropped by the client due
> + // to late arrival time (with latency < 0).
> + // This field set to UINT32_MAX and num_frames set to 0 indicate stream
> + // not supported by client.
What is missing on the doc above where it says:
| // A special case is when num_frames == 0 and num_drops ==
| // 0xffffffffu, this is used in the client to communicate that
| // the stream is not supported or that the client was not able
| // to decode it
> uint32 num_drops;
> // end_frame_mm_time - client_mm_time
> int32 last_frame_delay;
> --
> 2.17.1
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180705/3ee7f2f5/attachment.sig>
More information about the Spice-devel
mailing list