[Spice-devel] [PATCH spice-common] meson: Do not define -DGLIB_VERSION_MAX_ALLOWED

[Frediano Ziglio]

> 
> On Fri, Jul 06, 2018 at 05:33:45PM +0200, Christophe Fergeau wrote:
> > Ok, g_abort() is only available in 2.50, and only the meson build uses
> > GLIB_VERSION_MAX_ALLOWED. However, since this can be useful, I'd prefer
> > that we keep GLIB_VERSION_MAX_ALLOWED, and add it to the autotools
> > build. This specific issue can be fixed by using g_error() instead of
> > g_abort(). I'll send patches for that.
> 
> FYI, if you can rely on $CC always being CLang or GCC, there's a clever
> trick you can do to keep GLIB_VERSION_MAX_ALLOWED while still using newer

Visual Studio compiler has pragma warning to do the same trick (disable
deprecated warnings locally).

> APIs, with locally implemented back-compat wrappers. Take a look at this
> QEMU example with g_strv_contains:
> 
> https://git.qemu.org/gitweb.cgi?p=qemu.git;a=blob;f=include/glib-compat.h;h=fdf95a255d9c7b8a452d76b121a7839b24ac3908;hb=HEAD#l29
> 
> Regards,
> Daniel

Thanks,
  Frediano