[Spice-devel] [PATCH spice-common] meson: Disable -std=c99

[Christophe Fergeau]

In the shortlog, s/disable/remove/

On Mon, Jul 09, 2018 at 09:04:07AM +0100, Frediano Ziglio wrote:
> This flag disable some compiler feature which is used by some
> system header potentially introducing some limitations.
> Autotools does not set this flag.

Autotools checks whether this flag is needed or not though, and mandates
the use of at least c99
configure.ac has a call to AC_PROG_CC_C99 which translates to:

configure:13330: checking for gcc option to accept ISO C99
configure:13492: result: none needed

(just something that I would expand on in the commit log).

Christophe

> For instance some Posix limitations changes (like _POSIX_OPEN_MAX).
> As compiler feature for instance _Static_assert is not used.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  meson.build | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 2b91e82..466bb06 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -10,8 +10,7 @@ if not meson.is_subproject()
>  endif
>  
>  # some global vars
> -spice_common_global_cflags = ['-std=c99',
> -                              '-DHAVE_CONFIG_H',
> +spice_common_global_cflags = ['-DHAVE_CONFIG_H',
>                                '-DG_LOG_DOMAIN="Spice"',
>                                '-Wall',
>                                '-Wextra',
> -- 
> 2.17.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180709/f3442cb9/attachment.sig>