[Spice-devel] [PATCH spice-common] meson: Disable -std=c99

[Christophe Fergeau]

On Mon, Jul 09, 2018 at 05:41:42AM -0400, Frediano Ziglio wrote:
> > 
> > In the shortlog, s/disable/remove/
> > 
> 
> I'll update
> 
> > On Mon, Jul 09, 2018 at 09:04:07AM +0100, Frediano Ziglio wrote:
> > > This flag disable some compiler feature which is used by some
> > > system header potentially introducing some limitations.
> > > Autotools does not set this flag.
> > 
> > Autotools checks whether this flag is needed or not though, and mandates
> > the use of at least c99
> > configure.ac has a call to AC_PROG_CC_C99 which translates to:
> > 
> > configure:13330: checking for gcc option to accept ISO C99
> > configure:13492: result: none needed
> > 
> 
> The difference is that autotools looks for additional flag to support
> it while Meson add the flag to cap to C99.

Yes, this is exactly what I meant, I understand the difference ;)

> So if your compiler by default uses C89 and needs an additional flag
> autotools will add the additional flags, Meson adds -std=c99 to avoid
> for instance compiler use C11 features where in this case autotools
> won't add any flag.
> 
> Maybe change
> 
> "Autotools does not set this flag."
> 
> to
> 
> "Autotools won't add any flag to limit compiler features to C99, instead
> currently add for flag needed to support C99."

"instead it currently only add flags to support c99 when needed" ?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180709/43c7d606/attachment.sig>