[Spice-devel] [PATCH v3 spice-streaming-agent 0/1] Adding gstreamer based plugin

[Frediano Ziglio]

> 
> Changes since v2:
> -Adding support in h265
> -printing and logging changes
> -Fixes according to previous comments
> -Rebase
> 
> 
> 
> *Switching between capturing method is still using the XLIB CAPTURE
>  macro, hopefully the whole xlib capturing system could be dropped soon
> *Logging and printing are currently done using syslog but I'm not sure
>  we want syslog to get all of these
> *As mentioned before, registration of the plugin is done once, according
>  to the user input
> *Can be pulled from here:
> 	https://gitlab.com/sheriber/spice-streaming-agent/tree/gst-plugin
> 

Started writing some follow ups, see https://cgit.freedesktop.org/~fziglio/spice-streaming-agent/log/?h=gst_plugin
Mainly 2 categories:
- style (spaces, alignment and some C++), some are really minor;
- smart pointers (std::unique_ptr usages) and memory related stuff.

Wondering if would make sense to also update the spec file to produce
another package.

I still need to test more.

Frediano
 
> 
> Snir Sheriber (1):
>   Adding gstreamer based plugin
> 
>  configure.ac       |  15 ++
>  src/Makefile.am    |  27 +++
>  src/gst-plugin.cpp | 435 +++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 477 insertions(+)
>  create mode 100644 src/gst-plugin.cpp
>