[Spice-devel] [PATCH spice-server] red-stream-device: Fix leaks in dispose and finalize chaining parent

Frediano Ziglio fziglio at redhat.com
Wed Jul 11 15:37:14 UTC 2018


dispose and finalize methods have to call parent relative
cleanup method to avoid leaking resources.

Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
---
 server/red-stream-device.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/server/red-stream-device.c b/server/red-stream-device.c
index 77d0acd06..d293dc1cc 100644
--- a/server/red-stream-device.c
+++ b/server/red-stream-device.c
@@ -586,6 +586,8 @@ stream_device_dispose(GObject *object)
         red_channel_destroy(RED_CHANNEL(dev->cursor_channel));
         dev->cursor_channel = NULL;
     }
+
+    G_OBJECT_CLASS(stream_device_parent_class)->dispose(object);
 }
 
 static void
@@ -597,6 +599,8 @@ stream_device_finalize(GObject *object)
     dev->msg = NULL;
     dev->msg_len = 0;
     dev->msg_pos = 0;
+
+    G_OBJECT_CLASS(stream_device_parent_class)->finalize(object);
 }
 
 void
-- 
2.17.1



More information about the Spice-devel mailing list