[Spice-devel] [spice-html5] display: Dump bitmap metadata in log_draw()

[Jeremy White]

>>> diff --git a/display.js b/display.js
>>> index 7719b23..c55b686 100644
>>> --- a/display.js
>>> +++ b/display.js
>>> @@ -769,6 +769,12 @@ SpiceDisplayConn.prototype.log_draw = function(prefix, draw)
>>>                str += "; src_bitmap type " + draw.data.src_bitmap.descriptor.type + ", flags " + draw.data.src_bitmap.descriptor.flags;
>>>                if (draw.data.src_bitmap.surface_id !== undefined)
>>>                    str += "; src_bitmap surface_id " + draw.data.src_bitmap.surface_id;
>>> +            if (draw.data.src_bitmap.bitmap)
>>> +                str += "; BITMAP format " + draw.data.src_bitmap.bitmap.format +
>>> +                        "; flags " + draw.data.src_bitmap.bitmap.format +
>>
>> That looks like a repeat of the format, rather than the flags.
> 
> Yup, this duplicates the width/heigh info, however this also has the
> stride which is not present in the other places. Showing this is the
> main goal of the patch, as I did not go as far as fixing the actual bug
> (too unfamiliar with js :-/)

Ah, I think you misunderstood.  I wasn't concerned about the extra info, 
it's that I noticed that you supply a label of 'flags', but then 
actually pass in the format, which looks to be a copy/paste bug.

Cheers,

Jeremy