[Spice-devel] [spice-html5 v2] display: Dump bitmap metadata in log_draw()

Christophe Fergeau cfergeau at redhat.com
Tue Jul 17 15:18:16 UTC 2018


log_draw() is used to debug drawing commands by dumping drawing
information to the JS console. This commit adds dumping of missing data
for uncompressed bitmaps. The 'stride' parameter is important, as
spice-html5 currently does not deal properly with such bitmaps.

Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
---
 display.js | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/display.js b/display.js
index 7719b23..f6c74f5 100644
--- a/display.js
+++ b/display.js
@@ -769,6 +769,12 @@ SpiceDisplayConn.prototype.log_draw = function(prefix, draw)
             str += "; src_bitmap type " + draw.data.src_bitmap.descriptor.type + ", flags " + draw.data.src_bitmap.descriptor.flags;
             if (draw.data.src_bitmap.surface_id !== undefined)
                 str += "; src_bitmap surface_id " + draw.data.src_bitmap.surface_id;
+            if (draw.data.src_bitmap.bitmap)
+                str += "; BITMAP format " + draw.data.src_bitmap.bitmap.format +
+                        "; flags " + draw.data.src_bitmap.bitmap.flags +
+                        "; x " + draw.data.src_bitmap.bitmap.x +
+                        "; y " + draw.data.src_bitmap.bitmap.y +
+                        "; stride " + draw.data.src_bitmap.bitmap.stride ;
             if (draw.data.src_bitmap.quic)
                 str += "; QUIC type " + draw.data.src_bitmap.quic.type +
                         "; width " + draw.data.src_bitmap.quic.width +
-- 
2.17.1



More information about the Spice-devel mailing list