[Spice-devel] [PATCH v2 2/2] Fix clang build error on missing <errno.h>

Christophe Fergeau cfergeau at redhat.com
Wed Jul 18 08:49:29 UTC 2018


On Tue, Jul 17, 2018 at 05:56:15PM +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin <dinechin at redhat.com>
> 
> Using errno requires <errno.h>. Some platforms/compilers
> are stricter than others in this respect.
> 
> frame-log.cpp:27:96: error: use of undeclared identifier 'errno'
>            throw Error(std::string("Failed to open log file '") + log_name + "': " + strerror(errno));
> 
> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> ---
>  src/frame-log.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/frame-log.cpp b/src/frame-log.cpp
> index 63a8ac0..cc993cd 100644
> --- a/src/frame-log.cpp
> +++ b/src/frame-log.cpp
> @@ -12,6 +12,7 @@
>  #include <chrono>
>  #include <cstdarg>
>  #include <string.h>
> +#include <errno.h>

I'd try to keep this list alphabetically ordered

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180718/59d13098/attachment.sig>


More information about the Spice-devel mailing list