[Spice-devel] [spice-server 3/3] dcc: Fix QUIC fallback in get_compression_for_bitmap()

[Christophe Fergeau]

On Thu, Jul 19, 2018 at 11:35:54AM -0400, Frediano Ziglio wrote:
> Would be great to have a test case for this.
> As the image was uncompressed this possibly affected also
> network usage :-(

Yes, tried to measure network bandwidth before/after this patch, and
when this bug triggers, it seemed network usage was 10 times larger (but
this was a very crude measurement with wireshark stats while moving the
move in the VM). However I'm not sure we can get in the problematic
situation when using remote-viewer. To trigger this, you need to get
bitmaps with a stride bigger than their width (ie with padding), I've
only observed that when connecting to the VM with spice-html5 first (but
I haven't run extensive testing to see whether this is common or not).

Christophe

> 
> Frediano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180719/dd1a8048/attachment.sig>