[Spice-devel] [PATCH spice-gtk 4/4] fixup! build-sys: bump gtk requirement 3.12 -> 3.22

Frediano Ziglio fziglio at redhat.com
Fri Jul 20 17:17:12 UTC 2018


Add needed  G_GNUC_BEGIN_IGNORE_DEPRECATIONS/G_GNUC_END_IGNORE_DEPRECATIONS
for gtk_widget_set_double_buffered, looking at documentation
maybe gtk_widget_set_double_buffered calls should be removed
---
 src/spice-widget.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/spice-widget.c b/src/spice-widget.c
index 3a330ada..711286b2 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -637,7 +637,9 @@ static void spice_display_init(SpiceDisplay *display)
                      "signal::realize", drawing_area_realize, display,
                      NULL);
     gtk_stack_add_named(d->stack, area, "draw-area");
+    G_GNUC_BEGIN_IGNORE_DEPRECATIONS
     gtk_widget_set_double_buffered(area, true);
+    G_GNUC_END_IGNORE_DEPRECATIONS
     gtk_stack_set_visible_child(d->stack, area);
 
 #if HAVE_EGL
@@ -652,7 +654,9 @@ static void spice_display_init(SpiceDisplay *display)
 #endif
     area = gtk_drawing_area_new();
     gtk_stack_add_named(d->stack, area, "gst-area");
+    G_GNUC_BEGIN_IGNORE_DEPRECATIONS
     gtk_widget_set_double_buffered(area, true);
+    G_GNUC_END_IGNORE_DEPRECATIONS
 
     gtk_widget_show_all(widget);
 
@@ -1271,7 +1275,9 @@ static void set_egl_enabled(SpiceDisplay *display, bool enabled)
          * only way I found to prevent glitches when the window is
          * resized. */
         GtkWidget *area = gtk_stack_get_child_by_name(d->stack, "draw-area");
+        G_GNUC_BEGIN_IGNORE_DEPRECATIONS
         gtk_widget_set_double_buffered(GTK_WIDGET(area), !enabled);
+        G_GNUC_END_IGNORE_DEPRECATIONS
     } else
 #endif
     {
-- 
2.17.1



More information about the Spice-devel mailing list