[Spice-devel] [PATCH spice-server v4 2/2] Update gitlab-ci to use meson

[Frediano Ziglio]

> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> ---
>  .gitlab-ci.yml | 31 ++++++++++++++++++++++++++++++-
>  1 file changed, 30 insertions(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 50fb7a15..da86ef4a 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -4,7 +4,7 @@ before_script:
>    - >
>      dnf install 'dnf-command(copr)' git libtool make libasan orc-devel
>      python3 python3-six python3-pyparsing glib-networking
> -    asciidoc bzip2
> +    asciidoc bzip2 meson ninja-build
>      -y
>    - dnf copr enable @spice/nightly -y
>    - dnf builddep spice -y
> @@ -18,6 +18,15 @@ makecheck:
>    - make
>    - make -C server check || (cat server/tests/test-suite.log && exit 1)
>  
> +meson-makecheck:
> +  script:
> +  - >
> +    CFLAGS='-O2 -pipe -g -fsanitize=address -fno-omit-frame-pointer
> -Wframe-larger-than=40920'
> +    LDFLAGS='-fsanitize=address -lasan'
> +    meson build -Dcelt051=true || (cat build/meson-logs/meson-log.txt &&
> exit 1)
> +  - ninja -C build
> +  - (cd build && meson test) || (cat build/meson-logs/testlog.txt && exit 1)
> +
>  # check non-standard options, currently
>  # --enable-statistics  compile statistic code
>  # --without-sasl       disable SASL
> @@ -27,6 +36,12 @@ options:
>    - make
>    - make -C server check || (cat server/tests/test-suite.log && exit 1)
>  
> +meson-options:
> +  script:
> +  - meson -Dstatistics=true -Dsasl=false -Dcelt051=false build
> +  - ninja -C build
> +  - (cd build && meson test) || (cat build/meson-logs/testlog.txt && exit 1)
> +
>  check-valgrind:
>    script:
>    - dnf install
>    https://download1.rpmfusion.org/free/fedora/rpmfusion-free-release-$(rpm
>    -E %fedora).noarch.rpm -y
> @@ -41,6 +56,20 @@ check-valgrind:
>    - make
>    - make check-valgrind || (cat server/tests/test-suite-memcheck.log && exit
>    1)
>  
> +meson-check-valgrind:
> +  script:
> +  - dnf install
> https://download1.rpmfusion.org/free/fedora/rpmfusion-free-release-$(rpm -E
> %fedora).noarch.rpm -y
> +  - dnf debuginfo-install spice-server glib2 -y
> +  - >
> +    dnf install valgrind
> +    gstreamer1-libav gstreamer1-plugins-ugly gstreamer1-plugins-good
> gstreamer1-plugins-bad-free
> +    -y
> +  - >
> +    CFLAGS='-O2 -pipe -g -D_FORTIFY_SOURCE=0'
> +    meson -Dextra-checks=true -Dcelt051=true build
> +  - ninja -C build
> +  - (cd build && meson test --wrap=valgrind) || (cat
> build/meson-logs/testlog.txt && exit 1)
> +

Here should be

  - (cd build && meson test --wrap=valgrind) || (cat build/meson-logs/testlog-valgrind.txt && exit 1)

(log file changes if you use wrap)

>  syntax-check:
>    script:
>    - ./autogen.sh --enable-celt051

Note that using valgrind tests take lot of time and fails,
see https://gitlab.freedesktop.org/freddy77/spice/-/jobs/12740.
Not clear why video-encoders test is failing.
Maybe we can just use autotools for the moment to check with
valgrind?
Note that default build for meson is debug while for autotools is more
a debugoptimized (-g -O2), this possibly for valgrind is a huge difference.
Also possibly debug builds do not catch some warnings that require more
optimizations at compile time.

Frediano