[Spice-devel] [PATCH spice-gtk ] ci: celt051 is disabled by autogen.sh, avoid of disable it again

Jonathon Jongsma jjongsma at redhat.com
Thu Jul 26 18:49:11 UTC 2018


On Thu, 2018-07-26 at 08:03 -0400, Frediano Ziglio wrote:
> > Subject: [Spice-devel] [PATCH spice-gtk ] ci: celt051 is disabled
> > by autogen.sh, avoid of disable it again
> > 
> 
> Got me a while to understand, not sure but I think is "..., avoid
> disabling it again"

Yep!

>  
> > ---
> > 
> > I wonder whether i should have enable it on the first script so
> > it will try to build also when it's enabled
> > 
> > ---
> >  .gitlab-ci.yml | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index e2c35ef..a34eb0e 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -10,7 +10,7 @@ before_script:
> >  
> >  makecheck:
> >    script:
> > -  - ./autogen.sh --enable-static --disable-celt051
> > +  - ./autogen.sh --enable-static
> >    - make -j4
> >    - make check
> >  
> > @@ -27,6 +27,5 @@ makecheck_simple:
> >          --enable-smartcard=no
> >          --enable-usbredir=no
> >          --enable-dbus=no
> > -        --disable-celt051
> >    - make -j4
> >    - make check
> 
> Patch looks good otherwise
> 
> Frediano


More information about the Spice-devel mailing list