[Spice-devel] [spice-common 2/2] build: Disable celt 0.5.1 by defaulto

Frediano Ziglio fziglio at redhat.com
Mon Jun 4 09:20:57 UTC 2018


typo: defaulto
renaulto ? https://www.youtube.com/watch?v=bAPz3BqV7kk ?

> 
> This version of the CELT codec has long been obsolete, and Opus support
> has been added nearly 5 years ago. It's time we move on and try to stop
> using Celt ;)
> 

https://www.youtube.com/watch?v=ROpy_XnSQD4
you are inspiring today.

> Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> ---
>  m4/spice-deps.m4 | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/m4/spice-deps.m4 b/m4/spice-deps.m4
> index cf0e048..5326329 100644
> --- a/m4/spice-deps.m4
> +++ b/m4/spice-deps.m4
> @@ -108,7 +108,7 @@ AC_DEFUN([SPICE_CHECK_SMARTCARD], [
>  
>  # SPICE_CHECK_CELT051
>  # -------------------
> -# Adds a --disable-celt051 switch in order to enable/disable CELT 0.5.1
> +# Adds a --enable-celt051 switch in order to enable/disable CELT 0.5.1
>  # support, and checks if the needed libraries are available. If found, it
>  will
>  # return the flags to use in the CELT051_CFLAGS and CELT051_LIBS variables,
>  and
>  # it will define a HAVE_CELT051 preprocessor symbol as well as a
>  HAVE_CELT051
> @@ -116,10 +116,10 @@ AC_DEFUN([SPICE_CHECK_SMARTCARD], [
>  #--------------------
>  AC_DEFUN([SPICE_CHECK_CELT051], [
>      AC_ARG_ENABLE([celt051],
> -        [  --disable-celt051       Disable celt051 audio codec (enabled by
> default)],,
> -        [enable_celt051="yes"])
> +        [  --enable-celt051       Enable celt051 audio codec (disabled by
> default)],,
> +        [enable_celt051="no"])
>  
> -    if test "x$enable_celt051" = "xyes"; then
> +    if test "x$enable_celt051" != "xno"; then
>          PKG_CHECK_MODULES([CELT051], [celt051 >= 0.5.1.1],
>          [have_celt051=yes], [have_celt051=no])
>      else
>          have_celt051=no

Otherwise,
Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano


More information about the Spice-devel mailing list