[Spice-devel] [spice-streaming-agent PATCH 1/2] spec: some small fixes

[Uri Lublin]

On 06/04/2018 12:25 PM, Frediano Ziglio wrote:
> 
>>
>> 1. break a long description line into two lines
>> 2. add changelog version of pre-release 0.1 version
>> 3. replace ChangeLog documentation file with NEWS
>>     (we try to keep NEWS updated, but not ChangeLog)
> 
> Agreed, for details better to refer to git directly.
> 
>>
>> Signed-off-by: Uri Lublin <uril at redhat.com>
>> ---
>>   spice-streaming-agent.spec.in | 9 +++++----
>>   1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
>> index 843bf07..5aba5f8 100644
>> --- a/spice-streaming-agent.spec.in
>> +++ b/spice-streaming-agent.spec.in
>> @@ -17,7 +17,8 @@ Requires(post): /usr/sbin/semanage
>>   Requires(postun): /usr/sbin/semanage
>>   
>>   %description
>> -An agent, running on a guest, sending video streams of the X display to a
>> remote client (over Spice)
>> +An agent, running on a guest, sending video streams of the X display
>> +to a remote client (over Spice)
>>
> 
> According to http://wiki.rosalab.ru/en/index.php/RPM_spec_file_syntax the
> wrapping should be at 80 characters, 

According to https://fedoraproject.org/wiki/Packaging:Guidelines:
"Also, please make sure that there are no lines in the
  description longer than 80 characters."

I do not think it is important to make it 80, but I don't mind
taking your version.

> so:
> 
> An agent, running on a guest, sending video streams of the X display to a remote
> client (over Spice)





>   
>>   %package devel
>>   Requires: spice-protocol >= @SPICE_PROTOCOL_MIN_VER@
>> @@ -55,7 +56,7 @@ fi
>>   
>>   
>>   %files
>> -%doc COPYING ChangeLog README
>> +%doc COPYING NEWS README
>>   %{_udevrulesdir}/90-spice-guest-streaming.rules
>>   %{_bindir}/spice-streaming-agent
>>   %{_sysconfdir}/xdg/autostart/spice-streaming.desktop
>> @@ -67,5 +68,5 @@ fi
>>   %{_libdir}/pkgconfig
>>   
>>   %changelog
>> -* Wed Aug 16 2017 Frediano Ziglio <fziglio at redhat.com>
>> -- Initial package
>> +* Wed Aug 16 2017 Frediano Ziglio <fziglio at redhat.com> 0.1-1
>> +- Initial package (pre-release)
> 
> Why not adding something instead of replacing?
> Also you should put your name if you are doing the change.
 >
 > Frediano
 >

This just marks that the first rpm created (locally) was
of version 0.1-1

I'm adding in the next patch version 0.2-1, and putting my name.


Thanks,
     Uri.