[Spice-devel] [PATCH spice-common] squash! build: Ensure we link with -lm if needed

Christophe Fergeau cfergeau at redhat.com
Mon Jun 4 14:43:24 UTC 2018


Dunno if we should go out of our way for this test, or if we could just
unconditionnally link libm.

either way is fine with me, and the proposed patch looks fine. I would
drop 'func' from it, and use 'hypot' directly.

Christophe

On Mon, Jun 04, 2018 at 02:03:43PM +0100, Frediano Ziglio wrote:
> ---
>  meson.build | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index de777db..27f70a9 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -87,6 +87,14 @@ foreach func : functions
>    endif
>  endforeach
>  
> +func = 'hypot'
> +libm = compiler.find_library('m', required : false)
> +if compiler.has_function(func, prefix : '#include <math.h>')
> +  spice_common_config_data.set('HAVE_ at 0@'.format(func.to_upper()), '1')
> +elif compiler.has_function(func, prefix : '#include <math.h>', dependencies : libm)
> +  spice_common_deps += libm
> +  spice_common_config_data.set('HAVE_ at 0@'.format(func.to_upper()), '1')
> +endif
>  
>  #
>  # check for mandatory dependencies
> -- 
> 2.17.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180604/4d5316b3/attachment.sig>


More information about the Spice-devel mailing list