[Spice-devel] [spice-common 5/7] build: Remove checks for functions which are never called

Frediano Ziglio fziglio at redhat.com
Tue Jun 5 08:36:30 UTC 2018


> 
> Grepping for 'pow', 'sqrt' or 'inet_ntoa' returns no results in
> spice-common code base.
> inet_ntoa use was removed in 9749e7e 'ssl-verify: Changed IPv4 hostname
> to IPv6' and pow/sqrt use in 384698a 'Remove GL support'
> ---
>  m4/spice-deps.m4 | 2 +-
>  meson.build      | 3 ---
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/m4/spice-deps.m4 b/m4/spice-deps.m4
> index 7955bd2..126f7e2 100644
> --- a/m4/spice-deps.m4
> +++ b/m4/spice-deps.m4
> @@ -62,7 +62,7 @@ AC_DEFUN([SPICE_CHECK_SYSDEPS], [
>      # do not check malloc or realloc, since that cannot be cross-compiled
>      checked
>      AC_FUNC_ERROR_AT_LINE
>      AC_FUNC_FORK
> -    AC_CHECK_FUNCS([dup2 floor inet_ntoa memmove memset pow sqrt])
> +    AC_CHECK_FUNCS([dup2 floor memmove memset])
>      AC_SEARCH_LIBS([hypot], [m], [], [
>          AC_MSG_ERROR([unable to find the hypot() function])
>      ])
> diff --git a/meson.build b/meson.build
> index 2cf2c3c..9c12467 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -74,11 +74,8 @@ functions = ['alloca',
>               'dup2',
>               'floor',
>               'fork',
> -             'inet_ntoa',
>               'memmove',
>               'memset',
> -             'pow',
> -             'sqrt',
>               'vfork']
>  
>  foreach func : functions

Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano


More information about the Spice-devel mailing list