[Spice-devel] [spice-common v2 0/7] build: Misc build system cleanups

Frediano Ziglio fziglio at redhat.com
Tue Jun 5 14:41:22 UTC 2018


> 
> Hey,
> 
> This series expands on the Celt 0.5.1/-lm series I sent earlier with some
> small
> additional cleanups. The main change is that celt will be disabled by
> default, and
> Opus will be enabled by default, with errors when I felt it was appropriate.
> 
> Changes since v1:
> - removed unneeded patch in patch #1
> - fixed 'test xx == xx' occurrences
> - removed "" from Opus error messages
> 
> Christophe
> 

Acked the series

> Christophe Fergeau (7):
>   build: Ensure we link with -lm if needed
>   build: Disable celt 0.5.1 by default
>   build: By default, error out if Opus is missing
>   build: Use AM_COND_IF
>   build: Remove checks for functions which are never called
>   build: Remove bitops.h
>   build: Move client sources to libspice_common_client_la_SOURCES
> 
>  common/Makefile.am |  9 +++--
>  common/bitops.h    | 87 ----------------------------------------------
>  common/meson.build |  1 -
>  common/quic.c      |  1 -
>  configure.ac       |  2 +-
>  m4/spice-deps.m4   | 50 ++++++++++++++++++--------
>  meson.build        | 24 ++++++++-----
>  meson_options.txt  |  7 +++-
>  8 files changed, 63 insertions(+), 118 deletions(-)
>  delete mode 100644 common/bitops.h
> 

Frediano


More information about the Spice-devel mailing list