[Spice-devel] [spice-common v2 2/3] meson: Remove check for vfork

Frediano Ziglio fziglio at redhat.com
Wed Jun 6 11:20:25 UTC 2018


> 
> Nothing in spice-common calls vfork. The autotools-based build can
> fallback to vfork if fork is not available/working through the
> AC_FUNC_FORK macro, but the meson build is not implementing this magic.
> However, fork() is only called once in backtrace.h, and this part of the
> code is optional (it's not compiled in on Windows for example), and
> anyway, I doubt anyone is going to try to compile SPICE code on a
> platform without fork, so we can remove this check, it's always possible
> to readd it when we have a clear bug report about what is
> missing/needed.
> 
> Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>

Acked

> ---
>  meson.build | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 02ebbd8..cb8a1ee 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -58,8 +58,7 @@ headers = ['alloca.h',
>             'sys/socket.h',
>             'sys/stat.h',
>             'sys/types.h',
> -           'unistd.h',
> -           'vfork.h']
> +           'unistd.h']
>  
>  foreach header : headers
>    if compiler.has_header(header)
> @@ -75,8 +74,7 @@ functions = ['alloca',
>               'floor',
>               'fork',
>               'memmove',
> -             'memset',
> -             'vfork']
> +             'memset']

OT: I think memset/memmove are in C standard since C89...

>  
>  foreach func : functions
>    if compiler.has_function(func)

Frediano


More information about the Spice-devel mailing list