[Spice-devel] [RFC/POC PATCH vd_agent 13/16] vdagent: Log the diddly doo X11 error

Frediano Ziglio fziglio at redhat.com
Wed Jun 6 16:56:44 UTC 2018


> 
> Signed-off-by: Lukáš Hrázký <lhrazky at redhat.com>
> ---
>  src/vdagent/x11-randr.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/vdagent/x11-randr.c b/src/vdagent/x11-randr.c
> index 803cf73..84c75f2 100644
> --- a/src/vdagent/x11-randr.c
> +++ b/src/vdagent/x11-randr.c
> @@ -38,6 +38,10 @@
>  
>  static int error_handler(Display *display, XErrorEvent *error)
>  {
> +    char buf[1024];
> +    XGetErrorText(display, error->error_code, buf, 1024);
> +    syslog(LOG_ERR, "X11 Error: %s", buf);
> +
>      vdagent_x11_caught_error = 1;
>      return 0;
>  }

Beside the title too slang patch looks good but I suppose that this
function is here to catch error and ignore them so why logging as
error something already expected?

Frediano


More information about the Spice-devel mailing list