[Spice-devel] [PATCH 0/0] Add support for h265/HEVC video codec

[Snir Sheriber]

Hi,


On 06/18/2018 05:27 PM, Christophe de Dinechin wrote:
> As a follow up to the question I asked during the weekly meeting, what is the plan for selecting between codecs?
>
> Easy case: client and agent have only one shared codec combination. We have to pick that one.
>
> More complicatwed: say both sides support h264, vp9 and h265. Which one do we pick?
>
> Right now, the only ranking I am aware of occurs in the agent, and based on existing code and earlier discussions with Frediano, it’s not clear if we want to use that ranking to sort codecs. It’s designed to sort plugins, not codecs. It would be easy to tweak it to rank h265 higher than h264, though.
>
> Thoughts?

I think we should pick it according to the rank that the was given to 
the plugin (by the plugin author).
The reason for it is that the one who wrote the plugin is the only one 
who can assess its quality.

For example i would assume it's better to pick our nvidia h264 plugin 
(hw) than a gstreamer based
plugin that uses gstreamer's nvenc with h265 (also hw), since although 
its h265 our nvidia plugin
works much better and should be more stable than gstreamer's nvenc based 
plugin.
iirc it is similar to the way gstreamer's rank its plugins. (and 
probably changing forcing a plugin or
let the define different rank somehow could be nice).

BTW- gst-plugin is currently does not register each one of the possible 
codecs plugin's, the codec is
picked by the user and registered with that pick .

Snir.


>
> Christophe
>
>
>> On 18 Jun 2018, at 11:20, Snir Sheriber <ssheribe at redhat.com> wrote:
>>
>> This series adds support in h265 protocol to spice (intended for
>> stream-channel streams)
>>
>> spice-common was also updated but bumping it in the other components
>> and changing its required spice-protocol version does not seem necessary
>>
>> changed:
>> spice-server
>> spice-protocol
>> spice-common
>> spice-gtk
>>
>>
>> -- 
>> 2.17.0
>>
>> _______________________________________________
>> Spice-devel mailing list
>> Spice-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/spice-devel