[Spice-devel] [spice-server] build: Remove check for CELT

[Christophe Fergeau]

On Wed, Jun 20, 2018 at 04:47:28AM -0400, Frediano Ziglio wrote:
> > 
> > spice-server does not have any code depending on libcelt, such code is
> > in spice-common. We can thus get rid of that check, especially as its
> > default got out of sync with spice-common after recent changes there.
> > 
> > Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> > ---
> >  configure.ac | 10 ----------
> >  1 file changed, 10 deletions(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 1e569c30a..d71f0989f 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -181,16 +181,6 @@ AC_SUBST(PIXMAN_CFLAGS)
> >  AC_SUBST(PIXMAN_LIBS)
> >  AS_VAR_APPEND([SPICE_REQUIRES], [" pixman-1 >= $PIXMAN_REQUIRED"])
> >  
> > -AC_ARG_ENABLE([celt051],
> > -              AS_HELP_STRING([--disable-celt051], [Disable celt051 audio
> > codec (enabled by default)]),,
> > -              [enable_celt051="yes"])
> > -
> > -if test "x$enable_celt051" = "xyes"; then
> > -    CELT051_REQUIRED=0.5.1.1
> > -    PKG_CHECK_MODULES(CELT051, celt051 >= $CELT051_REQUIRED,
> > -                      AS_VAR_APPEND([SPICE_REQUIRES], [" celt051 >=
> > $CELT051_REQUIRED"]))
> > -fi
> > -
> >  PKG_CHECK_MODULES(SSL, openssl >= 1.0.0)
> >  AC_SUBST(SSL_CFLAGS)
> >  AC_SUBST(SSL_LIBS)
> 
> Why not using SPICE_CHECK_CELT051 ?

This was what I initially did, before realizing nothing in spice-server
used the CELT flags, or the CELT #define..

> Probably not changing much by the way, simply the --help won't list celt option.

.. but it indeed makes sense to at least have it in --help.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180620/4ea23c3e/attachment.sig>