[Spice-devel] [RFC/POC PATCH spice-protocol 02/16] Create a version 2 of the VDAgentMonitorsConfig message

Lukáš Hrázký lhrazky at redhat.com
Wed Jun 20 09:51:02 UTC 2018


On Wed, 2018-06-20 at 11:37 +0200, Christophe Fergeau wrote:
> On Tue, Jun 19, 2018 at 05:30:46PM +0200, Lukáš Hrázký wrote:
> > I don't know. I've also just noticed today that the depth field
> > actually seems to be unused, besides being set in the client.
> 
> The windows agent uses it
> https://gitlab.freedesktop.org/spice/win32/vd_agent/blob/master/vdagent/vdagent.cpp#L627
> But I think recent (newer than win7?) Windows versions don't support
> 16bpp anyway.

Oh, that's where I forgot to look :) Thanks.

> > > If it’s opaque, 32-bit might be too small, e.g. to pass a Windows
> > > handle. Or is it part of the definition that these are necessarily
> > > small consecutive IDs and that the agent has to keep a mapping if
> > > they want to associate some pointer with it?
> > 
> > I think you have the same information I do here :) The xrandr output
> > IDs are the only thing we have atm. I never finished the implementation
> > of my crystal ball so I can't predict the future yet :)
> 
> Did you take a (quick) look at how this would be represented with
> wayland? I'd consider xorg as legacy at this point ;)

Yeah, no, I didn't :) I'll try. Though xorg is going to be a long-
living legacy, with us writing the streaming code for it and the HW
accelerated APIs are written for it...

> Christophe


More information about the Spice-devel mailing list