[Spice-devel] [PATCH] spice-common submodule: update url (add .git at the end)

Christophe Fergeau cfergeau at redhat.com
Wed Jun 20 09:55:30 UTC 2018


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Wed, Jun 20, 2018 at 12:28:58PM +0300, Uri Lublin wrote:
> With the move to gitlab.freedesktop.org the spice-common submodule
> url changed, and now ends with .git
> 
> Update .gitmodules to reflect that.
> 
> Without this patch git submodule update (and ./autogen.sh)
> fails on RHEL-7 (git version 1.8.3).
> On Fedora 28 (git version 2.17.1) it succeeds as it's successfully
> redirecting to spice-common.git url.
> 
> With git version 1.8.3:
> $ git submodule update
> Cloning into 'spice-common'...
> error: RPC failed; result=22, HTTP code = 404
> fatal: The remote end hung up unexpectedly
> Clone of 'https://gitlab.freedesktop.org/spice/spice-common' into submodule path 'spice-common' failed
> 
> Signed-off-by: Uri Lublin <uril at redhat.com>
> ---
> 
> If you are testing from an existing directory you can
> 
>   $ git config submodule.spice-common.url  # show old url
>   $ git submodule deinit .
>   $ git submodule init
>   $ git config submodule.spice-common.url  # show new url
>   $ git submodule update
> 
> ---
>  .gitmodules | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitmodules b/.gitmodules
> index 0c618ee13..ef8d8f9a5 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -1,3 +1,3 @@
>  [submodule "spice-common"]
>  	path = spice-common
> -	url = ../spice-common
> +	url = ../spice-common.git
> -- 
> 2.17.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180620/a2b9b6c2/attachment.sig>


More information about the Spice-devel mailing list