[Spice-devel] [PATCH v2 spice-streaming-agent 1/1] Adding gstreamer based plugin

[Lukáš Hrázký]

On Wed, 2018-06-20 at 12:55 +0300, Snir Sheriber wrote:
> Hi,
> 
> ...

> > > > > +
> > > > > +    encoders = gst_element_factory_list_get_elements(GST_ELEMENT_FACTORY_TYPE_VIDEO_ENCODER, GST_RANK_NONE);
> > > > > +    sink_caps = gst_caps_from_string(caps_ss.str().c_str());
> > > > > +    filtered = gst_element_factory_list_filter(encoders, sink_caps, GST_PAD_SRC, false);
> > > > > +    if (filtered) {
> > > > > +        printf("Available encoders:\n");
> > > > 
> > > > The printf() calls should be syslog()s?
> > > 
> > > No, Should be printed to user. (but should i use cout maybe? or
> > > something else?)
> > 
> > What is the intention with the messages then? They look like debug
> > messages to me. I still think it should be syslog(), if you run the
> > agent manually from the terminal, syslog does print to stderr. And I
> > think stderr is preferable to stdout.
> 
> Assuming that using this plugin is currently only for development and 
> testing, the intention
> was to let the user\developer\tester to know which codec has been picked 
> and print a list
> of other available codecs. (assuming whenever it runs this information 
> is desirable)

Sure, so I'd use syslog for that, it's the kind of info that belongs
there (I think this in particular is quite useful even to a non-
debugging developer). As I said, when you run the agent from the
command line, the syslog lines are printed to stderr and you see them.
And when you run it as a service, you find them in the syslog too.

Lukas

> ...