[Spice-devel] [PATCH spice-common 1/3] Update gitlab-ci to use meson

[Frediano Ziglio]

> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> ---
>  .gitlab-ci.yml | 18 +++++++++++++++---
>  1 file changed, 15 insertions(+), 3 deletions(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index d1288ec..2f9ec4d 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -1,12 +1,15 @@
>  image: fedora:latest
>  
>  before_script:
> -  - >
> -    dnf install 'dnf-command(copr)' git libtool make libasan
> -    python3 python3-six python3-pyparsing glib-networking
> +  - dnf -y install 'dnf-command(copr)' 'dnf-command(config-manager)'

config-manager no more necessary

> +  - dnf config-manager --set-enabled updates-testing

ditto

> +  - dnf install
> +    git libtool make libasan python3 python3-devel python3-six
> +    python3-pyparsing meson ninja-build gdk-pixbuf2-devel
>      -y
>    - dnf copr enable @spice/nightly -y
>    - dnf builddep spice -y
> +  - ln -sf /usr/bin/python3 /usr/bin/python #FIXME?

no more necessary with python3-devel

>  
>  makecheck:
>    script:
> @@ -16,3 +19,12 @@ makecheck:
>      ./autogen.sh --enable-extra-checks --enable-celt051
>    - make
>    - make check || (cat tests/test-suite.log && exit 1)
> +
> +meson-makecheck:
> +  script:
> +  - >
> +    CFLAGS='-O2 -pipe -g -fsanitize=address -fno-omit-frame-pointer
> -Wframe-larger-than=40920'
> +    LDFLAGS='-fsanitize=address -lasan'
> +    meson build -Dextra-checks=true -Dcelt501=true

Why not use release buildtype instead of -O2 ?
Well, need to be tested, don't know how the two (-O and buildtype
works together).
I noted that by default CFLAGS is something like '-O2 -g' so will
end with a kind of release (not -O0) but with debug (-g).
Not sure about Meson defaults. Note that some helpful warnings that
compilers can produce are not generated with -O0.

In my spice-common patch (similar) I also added a

  meson ... || (cat build/meson-logs/meson-log.txt && exit 1)

to get details of possible failures

> +  - ninja -C build
> +  - cd build && meson test

See also my recent (today) "ci: Build also using Meson" patch, they
are doing the same (but maybe neither solve all issues I mentioned).

Frediano