[Spice-devel] [PATCH spice-common 2/3] meson: Enable '-std=c99' build flag

Frediano Ziglio fziglio at redhat.com
Thu Jun 21 13:53:33 UTC 2018


> 
> The only file preventing this flag was bitops.h which has been removed
> since the following commit:
> 
> commit 992ebac6b511811c73559421a46732c5233118c1
> Author: Christophe Fergeau <cfergeau at redhat.com>
> Date:   Tue Jun 5 11:27:01 2018 +0200
> 
>     build: Remove bitops.h
> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index cb8a1ee..dd5127a 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -10,7 +10,7 @@ if not meson.is_subproject()
>  endif
>  
>  # some global vars
> -spice_common_global_cflags = [#'-std=c99', # fails compiling bitops.h
> +spice_common_global_cflags = ['-std=c99',
>                                '-DHAVE_CONFIG_H',
>                                '-DG_LOG_DOMAIN="Spice"',
>                                '-Wall',

Almost fine with this.
Was wondering what will happen when compiler by default will
switch to c11 or something more recent. Will we still stay with
c99?

Otherwise,
Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano


More information about the Spice-devel mailing list