[Spice-devel] libressl fix for spice-gtk

[Frediano Ziglio]

> 
> > 
> > On Wed, Jun 20, 2018 at 09:02:05AM -0400, Frediano Ziglio wrote:
> > > > 
> > > > Hi, I maintain the spice-gtk port in FreeBSD and noticed that in
> > > > spice-gtk-0.35, there was a fix for libressl but that fix needs to
> > > > only apply to older versions of libressl. Here is a patch that
> > > > implements this. Can we can get in the new version so I can remove our
> > > > patch? Thanks.
> > > > 
> > > > https://bz-attachments.freebsd.org/attachment.cgi?id=194274
> > > > 
> > > > -#if OPENSSL_VERSION_NUMBER < 0x10100000 ||
> > > > defined(LIBRESSL_VERSION_NUMBER)
> > > > +#if OPENSSL_VERSION_NUMBER < 0x10100000 ||
> > > > (defined(LIBRESSL_VERSION_NUMBER) && LIBRESSL_VERSION_NUMBER <
> > > > 0x20700000)
> > > 
> > > Hi,
> > >   can you send a proper formatted git patch?
> > > Is it only a single file? If not maybe would be good to have a common
> > > check.
> > 
> > Yup, I did turn this into a git commit, but did not send it because it
> > felt better to massage this check into something shared/shorter.
> > 
> > Christophe
> > 
> 
> Already did, see
> https://lists.freedesktop.org/archives/spice-devel/2018-June/044192.html
> https://lists.freedesktop.org/archives/spice-devel/2018-June/044193.html
> 

Forgot: all these checks are doing the same check however I don't know
if introducing a new macro somewhere is a good idea.
I don't know how much this will be reused, maybe we will need to
introduce new checks with different OpenSSL/LibreSSL combinations.

Frediano